Merge lp://staging/~elopio/ubuntu-sso-client/scheme_in_env into lp://staging/ubuntu-sso-client
Proposed by
Leo Arias
Status: | Merged |
---|---|
Approved by: | dobey |
Approved revision: | 1036 |
Merged at revision: | 1029 |
Proposed branch: | lp://staging/~elopio/ubuntu-sso-client/scheme_in_env |
Merge into: | lp://staging/ubuntu-sso-client |
Diff against target: |
87 lines (+12/-10) 4 files modified
ubuntu_sso/__init__.py (+4/-2) ubuntu_sso/account.py (+2/-2) ubuntu_sso/qt/sso_wizard_page.py (+4/-4) ubuntu_sso/utils/webclient/timestamp.py (+2/-2) |
To merge this branch: | bzr merge lp://staging/~elopio/ubuntu-sso-client/scheme_in_env |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey (community) | Approve | ||
Review via email: mp+159513@code.staging.launchpad.net |
Commit message
Changed the environment variables for sso auth and uone from hosts to urls.
To post a comment you must log in.
This is an overly complex change in order to accomplish the desired outcome. I see no need to do all this extra work by moving things to functions rather than constants (which may be imported/used by other applications and libraries as well). There's no need to break API to support the environment variable including the URL scheme as well as the host and port.