Merge lp://staging/~elementary-apps/pantheon-mail/link-dialog-hig into lp://staging/~elementary-apps/pantheon-mail/trunk
Proposed by
Danielle Foré
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~elementary-apps/pantheon-mail/link-dialog-hig |
| Merge into: | lp://staging/~elementary-apps/pantheon-mail/trunk |
| Diff against target: |
69 lines (+35/-16) 1 file modified
src/client/composer/composer-widget.vala (+35/-16) |
| To merge this branch: | bzr merge lp://staging/~elementary-apps/pantheon-mail/link-dialog-hig |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| elementary Apps team | Pending | ||
|
Review via email:
|
|||
Commit message
composer-
* Add icon, primary, and secondary text to link dialog
* Code style
* Remove dialog close button
* Make dialog unresizable
To post a comment you must log in.
Revision history for this message
| David Hewitt (davidmhewitt) wrote | # |
Unmerged revisions
- 2231. By Danielle Foré
-
make link dialog adhere to HIG
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
All looks/works great. I have one minor piece of feedback though. When you open the dialog, then go off to your web browser to copy the link, when you come back, the pre-filled "http://" in the text box is no longer selected. So you then have to either delete that or select it before pasting your link.
It would be good if that got re-selected when the dialog was brought into focus again if it's not too much work.