Code review comment for lp://staging/~elementary-apps/pantheon-files/single-method-construct

Revision history for this message
Danielle Foré (danrabbit) wrote :

Good catch!

Oops, you're right. Fixed.

I didn't touch that in this diff, so I'd prefer to change that in another diff. I was thinking of doing a branch to try to organize a little better. They're currently in the Marlin.View namespace, I was thinking of creating a Files.Widgets namespace and moving them into a Labels.vala or something. Do you think it's worth having 2 files (ValueLabel.vala and KeyLabel.vala) since they're such tiny classes?

You're right it shouldn't be, but it looks like it is in Granite.Widgets namespace in pantheon-files/libwidgets/Chrome/ImgEventBox.vala

« Back to merge proposal