Code review comment for lp://staging/~elachuni/ubuntu-webcatalog/metadata_api

Revision history for this message
Michael Nelson (michael.nelson) wrote :

14:01 < noodles> achuni: re your MP (sorry if we've chatted about this before), you've added the gzip_page decorator to your new handler - isn't that something we should do for the whole api (well, shouldn't apache be doing that whenever the client accepts gzip?)
14:02 < achuni> noodles: re: doing it in apache vs. the app, last time we discussed it the advantage was control & configurability, and both will end up calling basically the same underlying C library, so not much performance loss
14:03 < noodles> achuni: what would we not want to gzip (other than when client doesn't accept gzip)
14:03 < achuni> noodles: re: doing it across the whole api, it's the only call so far that return any amount of data
14:03 < noodles> achuni: sure, it just seems like a decision our code shouldn't even have to make. But great - tests look great :) +1
14:05 < achuni> noodles: yep, I don't think we lose much by enabling it across the board
14:05 < achuni> s/much/anything/
14:10 < noodles> achuni: Where do we actually set categories for an application? I thought it'd been removed in favour of departments, and can't see it in the import_app_install_data...
14:15 < achuni> noodles: in import_app_install_data, in process_desktop_file
14:15 < achuni> noodles: it instantiates a ArchiveApplicationForm
14:15 < achuni> noodles: that populates all fields in Application, except a few listed explicitly
14:16 < noodles> achuni: right, which is why my grep didn't find categories there. Sweet.
14:16 < achuni> yep

review: Approve

« Back to merge proposal