The change looks straight-forward except for one point, which you cleared up via irc
{{{
09:05 < noodles> achuni: is:
09:05 < noodles> serializer = get_serializer(content_type)
09:05 < noodles> returning a class, or an instance?
09:05 < noodles> The diff makes it look like it's a class.
09:06 < noodles> (ie. as if it should be get_serializer(content_type)() )
09:06 < achuni> it was a class
09:06 < achuni> now it should be an instance
09:07 < noodles> k... all good then, with that note :)
09:07 < achuni> (changed on lines 85..88 of the diff)
09:08 < achuni> as serializers are stateless now, there's no harm in keeping instances around
09:08 < noodles> ah right. That makes sense.
09:08 < achuni> (also get_serializer(foo)(data).serialize() was ugly :) )
09:08 < noodles> Yep
}}}
The change looks straight-forward except for one point, which you cleared up via irc
{{{ content_ type) content_ type)() ) foo)(data) .serialize( ) was ugly :) )
09:05 < noodles> achuni: is:
09:05 < noodles> serializer = get_serializer(
09:05 < noodles> returning a class, or an instance?
09:05 < noodles> The diff makes it look like it's a class.
09:06 < noodles> (ie. as if it should be get_serializer(
09:06 < achuni> it was a class
09:06 < achuni> now it should be an instance
09:07 < noodles> k... all good then, with that note :)
09:07 < achuni> (changed on lines 85..88 of the diff)
09:08 < achuni> as serializers are stateless now, there's no harm in keeping instances around
09:08 < noodles> ah right. That makes sense.
09:08 < achuni> (also get_serializer(
09:08 < noodles> Yep
}}}