Code review comment for lp://staging/~edwin-grubbs/launchpad/bug-421975-identity-location-ui-3

> === modified file 'lib/lp/registry/browser/person.py'
> --- lib/lp/registry/browser/person.py 2009-08-31 22:11:14 +0000
> +++ lib/lp/registry/browser/person.py 2009-09-01 17:01:46 +0000

...

> +class PersonEditIRCNicknamesView(LaunchpadFormView):
> +
> + schema = Interface
> +
> + @property
> + def page_title(self):
> + return smartquote("%s's IRC nicknames" % self.context.displayname)
> +
> + label = page_title
> +
> + @property
> + def cancel_url(self):
> + return canonical_url(self.context)
> +
> + @action(_("Save Changes"), name="save")
> + def save(self, action, data):

Can you report a bug and add an XXX that this form and action should
use schema and form validation?

> +class PersonEditJabberIDsView(LaunchpadFormView):
> + schema = Interface
> +
> + @property
> + def page_title(self):
> + return smartquote("%s's Jabber IDs" % self.context.displayname)
> +
> + label = page_title
> +
> + @property
> + def cancel_url(self):
> + return canonical_url(self.context)
> +
> + @action(_("Save Changes"), name="save")
> + def save(self, action, data):
> """Process the Jabber ID form."""

Can you report a bug and add an XXX that this form and action should
use schema and form validation?

> === modified file 'lib/lp/registry/stories/foaf/xx-person-edit-irc-ids.txt'
> --- lib/lp/registry/stories/foaf/xx-person-edit-irc-ids.txt 2009-08-13 15:12:16 +0000
> +++ lib/lp/registry/stories/foaf/xx-person-edit-irc-ids.txt 2009-09-01 17:01:46 +0000

This whole test is bad. I would prefer to see this as a view test. If I send you one will you consider replacing this test with it?

> === modified file 'lib/lp/registry/templates/person-editircnicknames.pt'
> --- lib/lp/registry/templates/person-editircnicknames.pt 2009-08-13 15:12:16 +0000
> +++ lib/lp/registry/templates/person-editircnicknames.pt 2009-09-01 15:51:26 +0000
> @@ -6,26 +6,18 @@
> xml:lang="en"
> lang="en"
> dir="ltr"

Remove the xml:lang, lang, and dir because base-layout provides these.

...