Code review comment for lp://staging/~edwin-grubbs/launchpad/bug-421975-identity-location-ui-3

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Summary
-------

Converted the following pages to UI 3.0.
    person-editircnicknames.pt
    person-editjabberids.pt
    person-editlocation.pt

Implementation details
----------------------

I converted two of the views to LaunchpadFormView so that I could
set the view.label, but I didn't separate the action into separate
validate and action methods, which would have been difficult.

Tests
-----

./bin/test -vv -t 'irc.txt|xx-person-edit-irc-ids.txt|jabber.txt|xx-person-edit-jabber-ids.txt|personlocation.txt|stories/location'

Demo and Q/A
------------

* Open http://launchpad.dev/~name16/+editircnicknames
* Open http://launchpad.dev/~name16/+editjabberids
* Open http://launchpad.dev/~name16/+editlocation

Lint
----

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/lp/registry/browser/person.py
  lib/lp/registry/stories/foaf/xx-person-edit-irc-ids.txt
  lib/lp/registry/templates/person-editircnicknames.pt
  lib/lp/registry/templates/person-editjabberids.pt
  lib/lp/registry/templates/person-editlocation.pt

== Pylint notices ==

lib/lp/registry/browser/person.py
    117: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
    118: [F0401] Unable to import 'lazr.config' (No module named config)
    119: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)

« Back to merge proposal