Merge lp://staging/~dylanmccall/update-manager/refactored-cellareapackage into lp://staging/update-manager
Proposed by
Dylan McCall
Status: | Merged |
---|---|
Approved by: | Barry Warsaw |
Approved revision: | 2589 |
Merged at revision: | 2588 |
Proposed branch: | lp://staging/~dylanmccall/update-manager/refactored-cellareapackage |
Merge into: | lp://staging/update-manager |
Diff against target: |
142 lines (+63/-49) 1 file modified
UpdateManager/UpdatesAvailable.py (+63/-49) |
To merge this branch: | bzr merge lp://staging/~dylanmccall/update-manager/refactored-cellareapackage |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Barry Warsaw (community) | Approve | ||
Review via email: mp+145040@code.staging.launchpad.net |
Description of the change
While playing with the package column (and pkg_area) in UpdatesAvailabl
To post a comment you must log in.
A few comments:
Line 51: s/not cell_number in/cell_number not in/
Line 104: I factored out the "len(cells) - 1" into a local variable outside the loop for readability and (possibly) improved performance.
Lines 105-108 can be better written as: cell_size. get(cell_ number, 0)
cell_size = self.cached_
Line 110: Removed unnecessary parens.
I'll fix those and sponsor this into trunk (and upload) along with your LP: #1105363 fix.