Code review comment for lp://staging/~drf54321/wicd/drf-experimental

Revision history for this message
Dan O'Reilly (oreilldf) wrote :

It's actually better if you don't implement placeholders at all. That way the ioctl backend will juse use the inherited methods in wnettools.py.

Also, a couple of things regarding the ioctl GetBitRate method:
1) You should use self.sock instead of creating another socket object.
2) You should create a global constant called SIOCGIWRATE and use that instead of 0x8B21 directly.
3) You're using a variable called 'ifreq' in the ioctl call, but it doesn't exist. I think you meant 'data'.

« Back to merge proposal