ubiquity

Merge lp://staging/~dpniel/ubiquity/fix-1480430 into lp://staging/ubiquity

fix-1480430
Merge into trunk

Proposed by Dan Chapman  on 2015-09-05

Status:	Merged
Approved by:	Mathieu Trudel-Lapierre on 2015-09-15
Approved revision:	6314
Merged at revision:	6325
Proposed branch:	lp://staging/~dpniel/ubiquity/fix-1480430
Merge into:	lp://staging/ubiquity
Diff against target:	29 lines (+19/-0) 1 file modified autopilot/ubiquity_autopilot_tests/tests/__init__.py (+19/-0)
To merge this branch:	bzr merge lp://staging/~dpniel/ubiquity/fix-1480430
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Mathieu Trudel-Lapierre	2015-09-05	Approve on 2015-09-14
Nicholas Skaggs (community)		Approve on 2015-09-08
Review via email: mp+270243@code.staging.launchpad.net

Description of the change

[Autopilot tests] Add workaround for write changes to disk dialog

Unfortunately the dialog buttons have not identifiable properties to be
able to select and click the continue button. So this patch resorts to
a lengthy sleep and keyboard navigation to continue the install.

I will file a separate bug about improving autopilot accessibility of
this dialog as it would mean a change happening in ubiquity itself which
I don't want to include in this commit

lp://staging/~dpniel/ubiquity/fix-1480430 updated on 2015-09-05

6314. By Dan Chapman  on 2015-09-05: Fix pep8 warnings

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2015-09-08:

Dan, can you comment on the bug you filed for this issue? It would be nice to include it in the comments.

review: Approve

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2015-09-11:

Could we not instead provide you a name for that button? Seems like it would be a more solid fix than pressing keys, even if this would work.

I'm happy to take changes to the UI, you don't need to limit yourself to autopilot integration :)

review: Needs Information

Revision history for this message

Dan Chapman  (dpniel) wrote on 2015-09-12:

After our IRC discussion i've dug into this a little more to refresh my memory. So when the buttons are added to the dialog[1] it's done using gtk.Dialog.add_button() [2].

With this approach I can't see any way that set_name() can be called on each button as the add_button takes care of creation for you with no option to add a name.

I'm happy to try and make changes to the UI with a bit of guidance on what would be the best approach to get name properties on the buttons

[1] http://bazaar.launchpad.net/~ubuntu-installer/ubiquity/trunk/view/head:/ubiquity/frontend/gtk_ui.py#L1789
[2] https://lazka.github.io/pgi-docs/#Gtk-3.0/classes/Dialog.html#Gtk.Dialog.add_button