Code review comment for lp://staging/~dpb/charms/precise/haproxy/fix-service-entries

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

FWIW, using this branch I get the second unit added correctly to haproxy:
--- /etc/haproxy/haproxy.cfg.one-unit 2014-01-21 12:14:08.228486964 +0000
+++ /etc/haproxy/haproxy.cfg 2014-01-21 12:16:45.186927000 +0000
@@ -28,6 +28,8 @@
     option httpchk GET / HTTP/1.0
     server message 10.55.32.209:80 check inter 5000 rise 2 fall 5 maxconn 4
     server message 10.55.32.209:81 check inter 5000 rise 2 fall 5 maxconn 4
+ server message 10.55.32.215:80 check inter 5000 rise 2 fall 5 maxconn 4
+ server message 10.55.32.215:81 check inter 5000 rise 2 fall 5 maxconn 4

 frontend haproxy-0-80
     bind 0.0.0.0:80

It also supported removing a unit correctly:
--- /etc/haproxy/haproxy.cfg.two-units 2014-01-21 12:18:58.645623297 +0000
+++ /etc/haproxy/haproxy.cfg 2014-01-21 12:19:05.136867001 +0000
@@ -28,8 +28,6 @@
     option httpchk GET / HTTP/1.0
     server message 10.55.32.209:80 check inter 5000 rise 2 fall 5 maxconn 4
     server message 10.55.32.209:81 check inter 5000 rise 2 fall 5 maxconn 4
- server message 10.55.32.215:80 check inter 5000 rise 2 fall 5 maxconn 4
- server message 10.55.32.215:81 check inter 5000 rise 2 fall 5 maxconn 4

 frontend haproxy-0-80
     bind 0.0.0.0:80

It also supported the adding of two units at once:
--- /etc/haproxy/haproxy.cfg.one-unit 2014-01-21 12:14:08.228486964 +0000
+++ /etc/haproxy/haproxy.cfg 2014-01-21 12:27:24.239249653 +0000
@@ -28,6 +28,10 @@
     option httpchk GET / HTTP/1.0
     server message 10.55.32.209:80 check inter 5000 rise 2 fall 5 maxconn 4
     server message 10.55.32.209:81 check inter 5000 rise 2 fall 5 maxconn 4
+ server message 10.55.32.106:80 check inter 5000 rise 2 fall 5 maxconn 4
+ server message 10.55.32.106:81 check inter 5000 rise 2 fall 5 maxconn 4
+ server message 10.55.32.203:80 check inter 5000 rise 2 fall 5 maxconn 4
+ server message 10.55.32.203:81 check inter 5000 rise 2 fall 5 maxconn 4

 frontend haproxy-0-80
     bind 0.0.0.0:80

« Back to merge proposal