Code review comment for lp://staging/~dpb/charm-tools/fix-test-env-1271745
Revision history for this message
| David Britton (dpb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
On Fri, Jan 24, 2014 at 3:47 PM, Marco Ceppi <email address hidden> wrote:
> Review: Needs Fixing
>
> I don't like that this sets /all/ the environment variables. I'd rather
> there be a whitelist of environment variables to pass to the tests as the
> testing environment will have very limited scope of env variables.
>
Fixed with corresponding test cases.
--
David Britton <email address hidden>