Code review comment for lp://staging/~doctormo/loco-team-portal/teams_page_design

Revision history for this message
Martin Owens (doctormo) wrote :

A few things fixed:

> 1) the "edit team details" link is missing

Link was there, used a different conditional, changed now to use new conditional.

> 2) conflict in loco_directory/templates/teams/team_detail.html

Merged in correctly.

> 3) left border and footer seem to be a bit broken

Fixed by removing spare closing div tag.

> 4) are the icons for irc/support/etc. obvious enough with just a tooltip?

We can ask the community or the design team, but good enough for now.

> 5) maybe use http://webchat.freenode.net/ instead of java.freenode.net?

Done, webchat is better.

> 6) what about teams that don't use freenode? (Korea, Lithuania, ..)

That'll need a schema change anyway, we'll need some sort of model conditional which can tell if the user specified an irc server or not. So shouldn't be addressed here in this merge request.

> 7) what about the admin/owner mugshots? can we make that a separate commit
> once we have that data in the LD?

Yep, that's all waiting on improvements to the models.

review: Needs Resubmitting

« Back to merge proposal