Code review comment for lp://staging/~doanac/uci-engine/apt-mirror-support

Revision history for this message
Vincent Ladeuil (vila) wrote :

Minor nit:

15 + with open(fname) as f:
16 + lines = f.readlines()
17 + with open(fname, 'w') as f:
18 + for line in lines:
19 + f.write(line.replace('archive.ubuntu.com', mirror))

Why not reading the file all at once and replace there ?

Any number to share about that improvement ?

review: Approve

« Back to merge proposal