Merge lp://staging/~doanac/ubuntu-ci-services-itself/webui-status into lp://staging/ubuntu-ci-services-itself

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 302
Merged at revision: 308
Proposed branch: lp://staging/~doanac/ubuntu-ci-services-itself/webui-status
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 120 lines (+85/-1)
4 files modified
webui/index.html (+1/-0)
webui/status.html (+33/-0)
webui/ticket.html (+2/-1)
webui/webui_status.js (+49/-0)
To merge this branch: bzr merge lp://staging/~doanac/ubuntu-ci-services-itself/webui-status
Reviewer Review Type Date Requested Status
Evan (community) Approve
Andy Doan (community) Approve
Vincent Ladeuil Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+209324@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-03-01.

Commit message

display health of all our ci web services via the webui

Description of the change

NOTE: something got messed up on dependent branches, i'm redoing now that its dep is in trunk.

display status of all our ci web services via the webui

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote : Posted in a previous version of this proposal

webui: add status display for ci services

Provide a simplified view of the status of each service known
to the webui.

Revision history for this message
Chris Johnston (cjohnston) wrote : Posted in a previous version of this proposal

I wonder if the link to "Status" should be "Component status" or something
similar. I think status may be too vague.

Revision history for this message
Andy Doan (doanac) wrote : Posted in a previous version of this proposal

On 03/01/2014 07:30 AM, Chris Johnston wrote:
> I wonder if the link to "Status" should be "Component status" or something
> similar. I think status may be too vague.

I was worried about the same thing. I don't like "component status"
because it feels too big be putting in a menu. Maybe someone with a
better vocabulary than me can come up with a good word for this?

Revision history for this message
Evan (ev) wrote : Posted in a previous version of this proposal
Revision history for this message
Andy Doan (doanac) wrote : Posted in a previous version of this proposal

I'm going to try "System Status" in my setup today and see how it looks. If that's terrible, i'll try Health.

Revision history for this message
Andy Doan (doanac) wrote : Posted in a previous version of this proposal

This should be ready now. I've changed the wording to "Engine Health"

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:302
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/webui-status/+merge/208917/+edit-commit-message

http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/268/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/268/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:302
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/webui-status/+merge/208917/+edit-commit-message

http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/270/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/270/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:302
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/274/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/274/rebuild

review: Approve (continuous-integration)
Revision history for this message
Vincent Ladeuil (vila) wrote : Posted in a previous version of this proposal

Shame I can't test it easily even manually :-/

'Engine Health' sounds good.

review: Approve
Revision history for this message
Evan (ev) wrote : Posted in a previous version of this proposal
review: Needs Information
Revision history for this message
Andy Doan (doanac) wrote : Posted in a previous version of this proposal

On 03/04/2014 04:59 AM, Evan Dandrea wrote:
> Was http://yuilibrary.com/yui/docs/datatable/ not a good fit here?

We don't have a consistent set of values coming back. So I was basically
just dumping the dictionary that comes back. I'm sure someone with
DataTables knowledge (which josepht has) could help me here.

As an example we'll get data back like this:

  = ppa-django/0
  {
   'launchpad_configured': true,
   'total ppas': 4,
   'available ppas': 1
  }

= bsb-restish/0
{
   'rabbit_configured': true,
}

I think this brings up 2 orthogonal decisions:

1) display strategy: should we use something more professional like
DataTables. And if so, should we do it in this MP? I'd say, use
DataTables, but convert in a follow-on MP. No strong opininion

2) data strategy: Maybe we should try and get these "json status
providers" to send status back in a more understood format that the
webui could provide more intelligent display on. I think "yes" for this,
and its probably not that hard. We could change the format to something
like:

  = ppa-django/0
  [
   {
     'label': 'launchpad_configured',
     'value': true,
     'status': 'PASS'
   },
   {
     'label': 'total ppas',
     'value': 4,
     'status': 'WARNING'
   },
   {
     'label': 'available ppas',
     'value': 0,
     'status': 'ERROR'
   }
  ]

is this worth shooting for in phase0?

Revision history for this message
Joe Talbott (joetalbott) wrote : Posted in a previous version of this proposal

On Tue, Mar 04, 2014 at 03:36:26PM -0000, Andy Doan wrote:
> On 03/04/2014 04:59 AM, Evan Dandrea wrote:
> > Was http://yuilibrary.com/yui/docs/datatable/ not a good fit here?
>
> We don't have a consistent set of values coming back. So I was basically
> just dumping the dictionary that comes back. I'm sure someone with
> DataTables knowledge (which josepht has) could help me here.
>
> As an example we'll get data back like this:
>
> = ppa-django/0
> {
> 'launchpad_configured': true,
> 'total ppas': 4,
> 'available ppas': 1
> }
>
> = bsb-restish/0
> {
> 'rabbit_configured': true,
> }
>
> I think this brings up 2 orthogonal decisions:
>
> 1) display strategy: should we use something more professional like
> DataTables. And if so, should we do it in this MP? I'd say, use
> DataTables, but convert in a follow-on MP. No strong opininion

I'd recommend a follow-on MP because I always end up with big messy
commits when I try to use data-tables.
>
> 2) data strategy: Maybe we should try and get these "json status
> providers" to send status back in a more understood format that the
> webui could provide more intelligent display on. I think "yes" for this,
> and its probably not that hard. We could change the format to something
> like:

I think "yes" too, but that adds coupling between each component and the
webui. Or at worst requires all components to adhere to a "standard"
status format.

Revision history for this message
Andy Doan (doanac) wrote : Posted in a previous version of this proposal

okay. i think the concensus is merge this and fix better later. I'll start on that now.

review: Approve
Revision history for this message
Evan (ev) wrote : Posted in a previous version of this proposal

+1

Revision history for this message
Chris Johnston (cjohnston) wrote : Posted in a previous version of this proposal
Revision history for this message
Andy Doan (doanac) wrote :

looks good now. re-acking.

review: Approve
Revision history for this message
Evan (ev) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches