Code review comment for lp://staging/~doanac/ubuntu-ci-services-itself/webui-status

Revision history for this message
Joe Talbott (joetalbott) wrote :

On Tue, Mar 04, 2014 at 03:36:26PM -0000, Andy Doan wrote:
> On 03/04/2014 04:59 AM, Evan Dandrea wrote:
> > Was http://yuilibrary.com/yui/docs/datatable/ not a good fit here?
>
> We don't have a consistent set of values coming back. So I was basically
> just dumping the dictionary that comes back. I'm sure someone with
> DataTables knowledge (which josepht has) could help me here.
>
> As an example we'll get data back like this:
>
> = ppa-django/0
> {
> 'launchpad_configured': true,
> 'total ppas': 4,
> 'available ppas': 1
> }
>
> = bsb-restish/0
> {
> 'rabbit_configured': true,
> }
>
> I think this brings up 2 orthogonal decisions:
>
> 1) display strategy: should we use something more professional like
> DataTables. And if so, should we do it in this MP? I'd say, use
> DataTables, but convert in a follow-on MP. No strong opininion

I'd recommend a follow-on MP because I always end up with big messy
commits when I try to use data-tables.
>
> 2) data strategy: Maybe we should try and get these "json status
> providers" to send status back in a more understood format that the
> webui could provide more intelligent display on. I think "yes" for this,
> and its probably not that hard. We could change the format to something
> like:

I think "yes" too, but that adds coupling between each component and the
webui. Or at worst requires all components to adhere to a "standard"
status format.

« Back to merge proposal