/me blinks, hold on, where is the logger used here ?
313 - # FIXME: There is still a hole somewhere, the ack below won't happen if
314 - # an exception occurs while calling 'notify' just above, tricky testing
315 - # ahead... -- vila 2014-02-06
That one is dead for good ! Well done and thanks ;)
> NOTE: I've removed a long fix-me in the test-runner:
> I think this needs to be opened as a bug
bug # ? :-p Or was I over concerned ?
64 + if params. get('cancelled' ):
Oh right advisory is needed here, glad I approved the previous one ;)
84 - # remove from queue so request becomes completed
Hey, that's one of the comments I wanted in part 1/3 !
=== modified file 'image- builder/ imagebuilder/ run_worker. py'
/me blinks, hold on, where is the logger used here ?
313 - # FIXME: There is still a hole somewhere, the ack below won't happen if
314 - # an exception occurs while calling 'notify' just above, tricky testing
315 - # ahead... -- vila 2014-02-06
That one is dead for good ! Well done and thanks ;)
+1