Code review comment for lp://staging/~doanac/ubuntu-ci-services-itself/rabbit-queue-status

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> Andy Doan <email address hidden> writes:

    > On 03/09/2014 04:43 AM, Vincent Ladeuil wrote:
    >> 62 + '''checks if there any workers attached to the queue.'''
    >>
    >> 'are' missing ?

    > fixed in revno(335)

    >> 66 + # we already report rabbit isn't configured, so no sense adding
    >> 67 + # another failure for this
    >>
    >> Let's have a common way to report that error then, in the most obscure cases, it's better to have*some* output than none. I know this will never happen... but I know that if it happens, we'll be glad to have an error message;)

    > We are via the "add_rabbit_configured" in that object. My point was
    > we'll be reporting a "rabbit isn't configured" message already so
    > showing another error is just piling on extra stuff that might make it
    > more confusing to diagnose.

Ok, I was mistaken then, I thought the previous error was fatal and that
this one could only trigger if the config existed before and disappeared
for unknown reasons.

« Back to merge proposal