Code review comment for lp://staging/~doanac/ubuntu-ci-services-itself/deploy-with-oauth-tokens

Revision history for this message
Vincent Ladeuil (vila) wrote :

I think we should stay with what we've done so far, so env vars would have my preference.

If you could either add a check where we already check for OS_USERNAME, that would be helpful.

Failing that, mentioning it in the README will help those with a bad memory ;)

review: Approve

« Back to merge proposal