Code review comment for lp://staging/~diogenesethecynical/lernid/Bug793793
Revision history for this message
| John S. Gruber (jsjgruber) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
I suspect the code you are working on is back-level. There should be no import of gtkmozembed anymore. You may want to grab lp:lernid with bzr branch lp:lernid again. The latest revision should be numbered 228 and tagged as 0.8.1.5 . If you go to the top lernid directory and do fgrep -r gtkmozembed you should only get one hit, for the debian/changelog entry for the change that eliminated mention of gtkmozembed (thanks to Chris Coulson).
You do understand me about using urlparse--I'd only suggest url = "http://" + url so the order of the two items is correct. I do think using urlparse is more flexible.
>>> url='www.me.com'
>>> url
'www.me.com'
>>> url += 'http://
>>> url
'www.me.comhttp://'
>>>