Code review comment for lp://staging/~dimitern/juju-core/050-api-bulk-ops-units-2

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

On 2013/06/03 05:42:20, wallyworld wrote:
> See my top level comments here are similar to those made for the other
branch.
> Remote calls should all be routed via the service layer and not
attached to
> domain objects. I think it would be easier to discuss this on a call
rather than
> back and forth via email.

Excerpt from IRC logs:
[08:18:51] <dimitern> wallyworld: client-side api stays as in state, as
agreed on the last call - we cannot change that now
[08:19:07] <dimitern> wallyworld: it'll require rewritting everything
[08:19:31] <dimitern> wallyworld: but it's a transitional state towards
having bulk support on the server
[08:19:56] <dimitern> wallyworld: and eventually the agents can benefit
from that (one at a time) when refactored
[08:22:25] <wallyworld> dimitern: we need to discuss. i'm on a call
right now. perhaps after standup. the way it is now is fundamentally
broken because it is 1. stateful, 2. not connectionless, 3. not service
oriented
[08:23:11] <dimitern> wallyworld: none of these 3 things can change in a
single CL
<dimitern> wallyworld: as i said, changing the client-side api needs to
happen once the state api itself is changed accordingly
<dimitern> wallyworld: what's important is to have the api server-side
right first, which is what the cl does
<dimitern> wallyworld: but by all means, another discussion is in order
with me, you, fwereade and rogpeppe

https://codereview.appspot.com/9797046/

« Back to merge proposal