Code review comment for lp://staging/~dimitern/juju-core/038-upgrade-charm-switch

Revision history for this message
William Reade (fwereade) wrote :

LGTM with suggestions

https://codereview.appspot.com/8540050/diff/25002/cmd/juju/upgradecharm.go
File cmd/juju/upgradecharm.go (left):

https://codereview.appspot.com/8540050/diff/25002/cmd/juju/upgradecharm.go#oldcode100
cmd/juju/upgradecharm.go:100: } else if _, bumpRevision =
ch.(*charm.Dir); !bumpRevision {
We could just not bother checking this, and always setting bumpRevision
in local repos -- I don't think many people are putting bundles in local
repos anyway, and the error message from PutCharm should be clear enough
to anyone who is.

https://codereview.appspot.com/8540050/diff/25002/cmd/juju/upgradecharm.go
File cmd/juju/upgradecharm.go (right):

https://codereview.appspot.com/8540050/diff/25002/cmd/juju/upgradecharm.go#newcode153
cmd/juju/upgradecharm.go:153: // case (and the other error below). LP
bug #1174287
Move this comment up to the top case.

https://codereview.appspot.com/8540050/

« Back to merge proposal