https://codereview.appspot.com/8540050/diff/25002/cmd/juju/upgradecharm.go#oldcode100
cmd/juju/upgradecharm.go:100: } else if _, bumpRevision =
ch.(*charm.Dir); !bumpRevision {
We could just not bother checking this, and always setting bumpRevision
in local repos -- I don't think many people are putting bundles in local
repos anyway, and the error message from PutCharm should be clear enough
to anyone who is.
LGTM with suggestions
https:/ /codereview. appspot. com/8540050/ diff/25002/ cmd/juju/ upgradecharm. go upgradecharm. go (left):
File cmd/juju/
https:/ /codereview. appspot. com/8540050/ diff/25002/ cmd/juju/ upgradecharm. go#oldcode100 upgradecharm. go:100: } else if _, bumpRevision =
cmd/juju/
ch.(*charm.Dir); !bumpRevision {
We could just not bother checking this, and always setting bumpRevision
in local repos -- I don't think many people are putting bundles in local
repos anyway, and the error message from PutCharm should be clear enough
to anyone who is.
https:/ /codereview. appspot. com/8540050/ diff/25002/ cmd/juju/ upgradecharm. go upgradecharm. go (right):
File cmd/juju/
https:/ /codereview. appspot. com/8540050/ diff/25002/ cmd/juju/ upgradecharm. go#newcode153 upgradecharm. go:153: // case (and the other error below). LP
cmd/juju/
bug #1174287
Move this comment up to the top case.
https:/ /codereview. appspot. com/8540050/