Code review comment for lp://staging/~dimitern/juju-core/038-upgrade-charm-switch

Sorry, forgot to reply to these - all done.

https://codereview.appspot.com/8540050/diff/10001/cmd/juju/upgradecharm.go
File cmd/juju/upgradecharm.go (right):

https://codereview.appspot.com/8540050/diff/10001/cmd/juju/upgradecharm.go#newcode123
cmd/juju/upgradecharm.go:123: latest, err := repo.Latest(curl)
On 2013/04/26 15:06:33, rog wrote:
> i think this still isn't quite right.
> if someone specifies a revision number in the charm url, this means we
then
> discard it and use the latest revision anyway.

> i think fwereade's earlier suggestion is sound ("bump-revision logic
should
> apply when --switch is given
> with a local charm url without an explicit revision")

> AFAICS this code doesn't implement that logic.

Done.

https://codereview.appspot.com/8540050/