Code review comment for lp://staging/~dimitern/juju-core/038-upgrade-charm-switch

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Please take a look.

https://codereview.appspot.com/8540050/diff/10001/cmd/juju/upgradecharm.go
File cmd/juju/upgradecharm.go (right):

https://codereview.appspot.com/8540050/diff/10001/cmd/juju/upgradecharm.go#newcode46
cmd/juju/upgradecharm.go:46: as the old charm.
On 2013/04/26 15:06:33, rog wrote:
> probably worth reflowing all this text.

Done.

https://codereview.appspot.com/8540050/diff/10001/cmd/juju/upgradecharm.go#newcode51
cmd/juju/upgradecharm.go:51: to upgrade to, rather than the newest one.
This cannot be combined with --switch.
On 2013/04/26 15:06:33, rog wrote:
> perhaps add:

> To specify a given revision number with --switch, give
> it in the charm URL, for instance cs:wordpress-5
> would specify revision number 5 of the wordpress charm.

> ?

Done.

https://codereview.appspot.com/8540050/diff/10001/cmd/juju/upgradecharm.go#newcode133
cmd/juju/upgradecharm.go:133: // This is not a local repository.
On 2013/04/26 15:06:33, rog wrote:
> i think that's self evident from the condition on the if statement.

Removed.

https://codereview.appspot.com/8540050/

« Back to merge proposal