Code review comment for lp://staging/~diegosarmentero/ubuntu-system-settings/update-battery

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I did a new round and testing, and remainingCapacity() seems wrong on the n4, which gives a > 90% charged info when the device is actually 10% charged :/

You might better import the battery plugin and get the charge info from there I think (sorry about that, I think we had issues with the qtsystems binding as well before but I don't remember the details)

Other small question, why don't use the visble = true/false to show/hide widgets?

review: Needs Fixing

« Back to merge proposal