Code review comment for lp://staging/~diego-fmpwizard/drizzle/plugin-functions-error-messages

Revision history for this message
Monty Taylor (mordred) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Could we change the error message and remove the word native? For that
matter, renaming the define from ER_WRONG_PARAMCOUNT_TO_NATIVE_FCT to
ER_WRONG_PARAMCOUNT_TO_FUNCTION might also be nice? I'm not sure we're
going to end up with a real distinction between native and non-native
functions anymore.

fmpwizard wrote:
> fmpwizard has proposed merging lp:~diego-fmpwizard/drizzle/plugin-functions-error-messages into lp:drizzle.
>
> Requested reviews:
> Drizzle-developers (drizzle-developers)
>
> UDF plugin functions and built-in function use the same error message when they both receive an incorrect number of parameters.
>
> See https://blueprints.launchpad.net/drizzle/+spec/functions-plugins-consistent-errors for more information.
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqUBUEACgkQ2Jv7/VK1RgGS/wCgpIOaImCZ99aD8IocPByEXZM7
4m8AnRn5B4jGP6q8i6EVtZnF21yItRns
=K8RJ
-----END PGP SIGNATURE-----

« Back to merge proposal