Merge lp://staging/~didrocks/unity-lens-music/add-local-radio into lp://staging/unity-lens-music
Proposed by
Didier Roche-Tolomelli
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Paweł Stołowski | ||||||||
Approved revision: | 86 | ||||||||
Merged at revision: | 83 | ||||||||
Proposed branch: | lp://staging/~didrocks/unity-lens-music/add-local-radio | ||||||||
Merge into: | lp://staging/unity-lens-music | ||||||||
Diff against target: |
668 lines (+354/-74) 10 files modified
Makefile.am (+1/-1) configure.ac (+1/-0) src/categories.vala (+2/-1) src/daemon.vala (+5/-1) src/rhythmbox-collection.vala (+99/-70) src/rhythmbox-scope.vala (+1/-1) src/track.vala (+7/-0) tests/Makefile.am (+45/-0) tests/assertions.vapi (+23/-0) tests/test-rhythmbox-parser.vala (+170/-0) |
||||||||
To merge this branch: | bzr merge lp://staging/~didrocks/unity-lens-music/add-local-radio | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paweł Stołowski (community) | Approve | ||
Review via email: mp+111875@code.staging.launchpad.net |
Commit message
Description of the change
This branch adds local radio detection from rhythmbox. The category will
only be placed after the "for purchase one" to be unobstrusive (LP: #969697)
Also fix the non translated "Unknown" album filter appearing for non english
users (LP: #1009069)
Add some tests for the parser part (radios and songs)
To post a comment you must log in.
1) I think we may need to adjust album handling logic in "search" method, as iradio records seem to have empty album names - I think we should skip album if TYPE == RADIO; see lines 654 - 665, i.e. from_album = !(album in albums_ list_nosearch) ; track_from_ album) results_ model, model, iter, ResultType.ALBUM, category_id);
bool first_track_
...
if (first_
...
add_result (search.
2) Can you use TrackType as the type of Track - type_track instead of int?