Merge lp://staging/~didrocks/ubuntu-release-upgrader/add_telemetry into lp://staging/ubuntu-release-upgrader
Proposed by
Didier Roche-Tolomelli
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | 3135 |
Merged at revision: | 3131 |
Proposed branch: | lp://staging/~didrocks/ubuntu-release-upgrader/add_telemetry |
Merge into: | lp://staging/ubuntu-release-upgrader |
Diff against target: |
549 lines (+176/-55) 8 files modified
DistUpgrade/DistUpgradeController.py (+16/-20) DistUpgrade/DistUpgradeView.py (+11/-7) DistUpgrade/DistUpgradeViewGtk3.py (+20/-16) DistUpgrade/DistUpgradeViewKDE.py (+14/-10) DistUpgrade/DistUpgradeViewNonInteractive.py (+3/-0) DistUpgrade/DistUpgradeViewText.py (+5/-2) DistUpgrade/telemetry.py (+101/-0) debian/changelog (+6/-0) |
To merge this branch: | bzr merge lp://staging/~didrocks/ubuntu-release-upgrader/add_telemetry |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Didier Roche-Tolomelli | Approve | ||
Brian Murray | Approve | ||
Review via email: mp+345088@code.staging.launchpad.net |
Commit message
Add upgrade telemetry data for later collect in ubuntu-report.
Description of the change
Add upgrade telemetry data for later collect in ubuntu-report.
This was tested with 17.04 -> 18.04 upgrade, in text mode, GTK3 and KDE.
To post a comment you must log in.
Keep in mind that it is possible to from one release to multiple releases e.g. from xenial to artful or bionic. So without knowing the database structure I think it would make sense to also record the "To" release. You can find this in DistUpgradeCont roller. py.
I'm also curious about how this information will be used because the use cases might benefit from gathering additional information like the version of release upgrader being used or environmental variables set.
Otherwise there are a couple of typos and one nitpick to have a look at.