Merge lp://staging/~didrocks/apport/handle-older-reports into lp://staging/~apport-hackers/apport/trunk
Proposed by
Didier Roche-Tolomelli
Status: | Merged |
---|---|
Merged at revision: | 3220 |
Proposed branch: | lp://staging/~didrocks/apport/handle-older-reports |
Merge into: | lp://staging/~apport-hackers/apport/trunk |
Diff against target: |
18 lines (+7/-2) 1 file modified
apport/ui.py (+7/-2) |
To merge this branch: | bzr merge lp://staging/~didrocks/apport/handle-older-reports |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brian Murray (community) | Approve | ||
Review via email: mp+354692@code.staging.launchpad.net |
Description of the change
Handle older reports without the remember key.
Old reports (generated pre-apport 2.20.10-0ubuntu4) may not have the remember key
and can be loaded afterwards (or after dist-upgrade), and thus, trigger a KeyError.
Consider it as false then.
Use try/expect for python2 support.
Fixes LP: #1791324
To post a comment you must log in.
Would be cleaner with response. get('remember' , False) IMO to avoid catching KeyErrors inside of self.remember_ send_report( )