Code review comment for lp://staging/~dgadomski/ubiquity/lp1749289

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

> I'll request a review from the ubuntu-installer team instead.

Thank you for taking a look Colin.

I've picked you manually since bzr pointed you as the author of the bin/oem-config-firstboot changes that were mutually exclusive (set -e vs handling the exit code of oem-config-wrapper) so I figured that you are the best person to verify what was the expected behavior there. Sadly there were no tests for that part of the code to dispel my doubts.

« Back to merge proposal