Merge lp://staging/~deryck/launchpad/hot-bugs-list-515232 into lp://staging/launchpad

This branch converts a bugtask.py's hot_bugtasks method to a hot_bugs
method on a bug target. The effect of this change is that the bugs home
page for a project will no longer feature the most recently changed
bugs. The home page will now show the top 10 hottest bugs.

This also fixes bug 442170, bug 77701, and bug 515232.

== Implementation details ==

One version of this landed during week 3 last cycle, but the branch was
reverted last minute due to timeout issues. After much playing on
staging with queries (and after talking with Björn), I feel confident
setting a limit and not doing a secondary sort on -datecreated will fix
the timeouts we had.

I also took the opportunity to clean up some lint and add a link to the
rest of the hot bugs list. Because I added this link, I needed a way to
check that more than 10 hot bugs exist. I made the hot_bugs list a dict
with a flag for has_more_bugs, which allows doing this in one method,
too, avoiding having to look up the hot bugs list again.

== Tests ==

Test with:

./bin/test -cvvt xx-product-bugs-page.txt

== Demo and Q/A ==

To QA, visit any bugs home page (e.g.
https://bugs.launchpad.net/malone/) and confirm that the 10 bugs shown
are the top ten when you follow the link to the full hot bugs list.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/browser/bugtarget.py
  lib/lp/bugs/browser/bugtask.py
  lib/lp/bugs/templates/bugtarget-bugs.pt
  lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt

Hi Deryck,

Woo! This is great :)

There are a few issues that need fixing up I think, but nothing that's
going to pose problems.

Gavin.

> === modified file 'lib/lp/bugs/browser/bugtarget.py'
> --- lib/lp/bugs/browser/bugtarget.py 2010-01-29 19:00:47 +0000
> +++ lib/lp/bugs/browser/bugtarget.py 2010-02-10 16:43:36 +0000
> @@ -40,6 +40,7 @@
> from canonical.config import config
> from lp.bugs.browser.bugtask import BugTaskSearchListingView
> from lp.bugs.interfaces.bug import IBug
> +from lp.bugs.interfaces.bugtask import BugTaskSearchParams
> from canonical.launchpad.browser.feeds import (
> BugFeedLink, BugTargetLatestBugsFeedLink, FeedsMixin,
> PersonLatestBugsFeedLink)
> @@ -55,6 +56,7 @@
> from canonical.launchpad.interfaces.launchpad import ILaunchpadCelebrities
> from canonical.launchpad.interfaces.temporaryblobstorage import (
> ITemporaryStorageManager)
> +from canonical.launchpad.searchbuilder import any
> from canonical.launchpad.webapp import urlappend
> from canonical.launchpad.webapp.breadcrumb import Breadcrumb
> from canonical.launchpad.webapp.interfaces import ILaunchBag, NotFoundError
> @@ -1264,6 +1266,28 @@
> else:
> return 'None specified'
>
> + @property
> + def hot_bugs(self):

It's not returning a straight list of hot bugs, so consider renaming
this to hot_bugtasks_info or something like that?

> + """Return a dict of the 10 hottest tasks and a has_more_bugs flag."""
> + has_more_bugs = False
> + params = BugTaskSearchParams(
> + orderby='-heat', omit_dupes=True,
> + user=self.user, status=any(*UNRESOLVED_BUGTASK_STATUSES))
> + # Use 4x as many tasks as bugs that are needed to improve performance.
> + bugtasks = self.context.searchTasks(params)[:40]
> + hot_bugs = []

This will contain bugtasks, so maybe rename it?

> + count = 0

len(hot_bugs) should contain the same number, and is authoritative, so
consider dropping count.

> + for task in bugtasks:
> + # Ensure we only represent a bug once in the list.
> + if task.bug not in [hot_task.bug for hot_task in hot_bugs]:

YOU'RE BURNING MY EYES!

:)

Actually, seeing as it's never going to create a temporary list of
more than 10 bugtasks, I guess it's not crazy. Still, to code
defensively, I think it would be better to accumulate the bugtask's
bugs in a set, and use that to test for membership.

> + if count < 10:
> + hot_bugs.append(task)
> + count += 1
> + else:
> + has_more_bugs = True
> + break
> + return {'has_more_bugs': has_more_bugs, 'bugtasks': hot_bugs}
> +
>
> class BugTargetBugTagsView(LaunchpadView):
> """Helper methods for rendering the bug tags portlet."""
>
> === modified file 'lib/lp/bugs/browser/bugtask.py'
> --- lib/lp/bugs/browser/bugtask.py 2010-01-26 14:22:41 +0000
> +++ lib/lp/bugs/browser/bugtask.py 2010-02-10 16:43:36 +0000
> @@ -2206,9 +2206,13 @@
> distrosourcepackage_context or sourcepackage_context):
> return ["id", "summary", "importance", "status",...

Hi, Gavin.

Thanks for the review! I knew I was doing some dumb things in there, but I was feeling a bit too close to it after so many iterations.

You had good recommendations all the way around, which I've implemented, except for a couple of them. I didn't change the test -- yes, it's fragile, but the whole point of the page test is to show the ordering of bugs by heat. Also, I needed at least status in the monster-long query to "show all bugs." I trimmed what I could, but it's still a bit long.

Otherwise, I think I took care of all your points.

Cheers,
deryck