Code review comment for lp://staging/~denys.duchier/bzr/bzr.ssl

Revision history for this message
Robert Collins (lifeless) wrote :

This looks broadly ok.

I wonder if it would be cleaner to pass in an object to run before_serve(socket), rather than forcing subclassing?

That would appear to be more generically useful to me.

Secondly, perhaps bzr+ssl would be less likely to have people make typographical errors during copy and paste and so forth.

review: Approve

« Back to merge proposal