Canonical SSO provider

Merge lp://staging/~deadlight/canonical-identity-provider/language into lp://staging/~deadlight/canonical-identity-provider/vanilla

  1. language
  2. Merge into vanilla
Proposed by Karl Williams
Status: Merged
Merge reported by: Karl Williams
Merged at revision: not available
Proposed branch: lp://staging/~deadlight/canonical-identity-provider/language
Merge into: lp://staging/~deadlight/canonical-identity-provider/vanilla
Prerequisite: lp://staging/~deadlight/canonical-identity-provider/ssh-keys
Diff against target: 119 lines (+37/-56)
1 file modified
src/webui/templates/select_language.html (+37/-56)
To merge this branch: bzr merge lp://staging/~deadlight/canonical-identity-provider/language
Reviewer Review Type Date Requested Status
Anthony Dillon (community) Approve
Karl Williams Pending
Review via email: mp+371657@code.staging.launchpad.net

Description of the change

Converted the language selection page to Vanilla

QA:
- npm i
- ./node_modules/gulp/bin/gulp.js sass
- source env/bin/activate
- make start-db
- make run
- Visit http://[CONTAINER IP]:8000/set_language

To post a comment you must log in.
lp://staging/~deadlight/canonical-identity-provider/language updated
1712. By Karl Williams

Styled selct language page with Vnailla Framework

Revision history for this message
Karl Williams (deadlight) wrote :

QA'd in person

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Two small suggestions

review: Needs Fixing
lp://staging/~deadlight/canonical-identity-provider/language updated
1713. By Karl Williams

Fix button style and add external link class

Revision history for this message
Karl Williams (deadlight) wrote :

Fixed issues raised in comments

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: