Go OpenStack Exchange

Merge lp://staging/~dave-cheney/goose/001-fmt-error into lp://staging/goose

  1. 001-fmt-error
  2. Merge into trunk
Proposed by Dave Cheney
Status: Merged
Approved by: Dave Cheney
Approved revision: 84
Merged at revision: 85
Proposed branch: lp://staging/~dave-cheney/goose/001-fmt-error
Merge into: lp://staging/goose
Diff against target: 73 lines (+8/-10)
3 files modified
errors/errors.go (+2/-3)
http/client.go (+5/-6)
nova/nova.go (+1/-1)
To merge this branch: bzr merge lp://staging/~dave-cheney/goose/001-fmt-error
Reviewer Review Type Date Requested Status
Dave Cheney Pending
Review via email: mp+159287@code.staging.launchpad.net

Commit message

goose/{errors,http}: fix format strings in errors.

Description of the change

goose/{errors,http}: fix error formatting

https://codereview.appspot.com/8818043/

To post a comment you must log in.
Revision history for this message
William Reade (fwereade) wrote :

LGTM trivial if tested live

https://codereview.appspot.com/8818043/

lp://staging/~dave-cheney/goose/001-fmt-error updated
84. By Dave Cheney

fixed another formatting error

Revision history for this message
John A Meinel (jameinel) wrote :

LGTM

Though we should have ways of exercising this code in tests. I filed
https://bugs.launchpad.net/goose/+bug/1169834 about it.

Thanks for tracking this down.

https://codereview.appspot.com/8818043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches