Code review comment for lp://staging/~darkxst/empathy/3.12

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work! That looks mostly good to me, some small comments/questions though

* the geoclue build-depends should be reverted to "geoclue" since the package keeps using the old version

* the debian/rules changes with ubuntu-online-account/powerpc doesn't seem explained in the changelog, could you give some details on it. Was the option implicit/depending of the build environment before and just being consistently enforced now? Why is powerpc as special case there?

* do you think you could turn the bug into a ffe request?

review: Needs Fixing

« Back to merge proposal