Merge lp://staging/~darkmuggle-deactivatedaccount/ubuntu/oneiric/glance/oneiric into lp://staging/~openstack-ubuntu-packagers/glance/ubuntu

Proposed by Ben Howard
Status: Merged
Merged at revision: 56
Proposed branch: lp://staging/~darkmuggle-deactivatedaccount/ubuntu/oneiric/glance/oneiric
Merge into: lp://staging/~openstack-ubuntu-packagers/glance/ubuntu
Diff against target: 122 lines (+55/-4)
7 files modified
debian/changelog (+9/-2)
debian/control (+1/-1)
debian/glance.install (+1/-0)
debian/glance.postrm (+18/-0)
debian/glance.prerm (+11/-0)
debian/patches/sql_conn.patch (+14/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp://staging/~darkmuggle-deactivatedaccount/ubuntu/oneiric/glance/oneiric
Reviewer Review Type Date Requested Status
Monty Taylor Approve
Clint Byrum (community) Needs Information
Dave Walker Pending
Review via email:

Description of the change

Install glance-scrubber.conf by default.

To post a comment you must log in.
57. By Ben Howard

Remove glance user and logs on purge (LP: #828721)

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hi Ben!

This will need to be changed a bit.

* 'service x x' is not really allowed in maintainer scripts. You will need to use 'invoke-rc.d glance-api stop' instead (this is so that users can override a package's desire to start/stop a service.)

* If you bump the standards, its good to assert that you did so and didn't need to change anything. You can see what changes are necessary by installing 'debian-policy' and reading /usr/share/doc/debian-policy/upgrading-checklist.txt.gz

Otherwise it looks good.

review: Needs Fixing
58. By Ben Howard

Fixed glance.postrm and changed service stop method to comply with standards

Revision history for this message
Ben Howard (darkmuggle-deactivatedaccount) wrote :

Applied fixe per Clint's comments.

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Looks good Ben. As per our out of band discussion, I'll follow up with the other people about whether this is ready to be uploaded.

review: Needs Information
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Monty, Dave, can you please +1 this and/or upload it directly?

I'm somewhat concerned with the --with python2 being added, as Monty had raised concerns that this makes the package harder to backport to lucid.

Revision history for this message
Monty Taylor (mordred) wrote :

I tested building this branch in a maverick chroot. It works just fine.

The problem I was bitching about earlier was due to the unnecessary inclusion of Build-dep: python-all (>= 2.6.6-3~) which is a meaningless line on oneiric but breaks maverick.

SO - all of that to say, this works fine for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches