neutron

Merge lp://staging/~danwent/neutron/client-lib into lp://staging/neutron/diablo

client-lib
Merge into diablo

Proposed by dan wendlandt on 2011-08-08

Status:	Merged
Approved by:	Salvatore Orlando on 2011-08-12
Approved revision:	39
Merged at revision:	40
Proposed branch:	lp://staging/~danwent/neutron/client-lib
Merge into:	lp://staging/neutron/diablo
Diff against target:	1482 lines (+675/-655) 4 files modified quantum/cli.py (+3/-3) quantum/client.py (+47/-27) tests/unit/api.py (+0/-625) tests/unit/test_clientlib.py (+625/-0)
To merge this branch:	bzr merge lp://staging/~danwent/neutron/client-lib
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Tyler Smith		Approve on 2011-08-09
Brad Hall (community)	2011-08-08	Approve on 2011-08-08
Review via email: mp+70752@code.staging.launchpad.net

Description of the change

Some minor tweaks to the Quantum Client Library, based on my experience using the library.

Already talked with Tyler about these changes and he is in favor.

Summary of the changes:
- Adding optional logging component.
- changing comments to be more consistent
- renamed a couple methods, so that a method only started with "list_" if it returned a list of items (warning: this change will break compatibility with existing code)

Revision history for this message

Brad Hall (bgh) wrote on 2011-08-08:

Looks good

review: Approve

Revision history for this message

Tyler Smith (tylesmit) wrote on 2011-08-09:

Looks great to me. Unit tests for the renamed methods are failing, but only because of the name change which I can fix along with the other updates to the library we discussed once this merge goes through.

review: Approve

Revision history for this message

dan wendlandt (danwent) wrote on 2011-08-09:

Great catch. I definitely want to fix the unit tests before committing. My
confusion came from the fact that the client_lib unit tests aren't run when
I do:

./run_tests.sh -N

I have renamed the unit tests file to start with test_ and now I am seeing
errors, which I will fix :)

Dan

On Tue, Aug 9, 2011 at 8:43 AM, Tyler Smith <email address hidden> wrote:

> Review: Approve
> Looks great to me. Unit tests for the renamed methods are failing, but
> only because of the name change which I can fix along with the other updates
> to the library we discussed once this merge goes through.
> --
> https://code.launchpad.net/~danwent/quantum/client-lib/+merge/70752
> You are the owner of lp:~danwent/quantum/client-lib.
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
Sr. Product Manager
cell: 650-906-2650
~~~~~~~~~~~~~~~~~~~~~~~~~~~

Revision history for this message

dan wendlandt (danwent) wrote on 2011-08-09:

Ok, now the client-lib unit tests should be run every time.

I also had to change the cli to use different call names... we really need
to get unit tests for the CLI and batch_config.py

dan

On Tue, Aug 9, 2011 at 9:13 AM, dan wendlandt <email address hidden> wrote:

> Great catch. I definitely want to fix the unit tests before committing.
> My
> confusion came from the fact that the client_lib unit tests aren't run when
> I do:
>
> ./run_tests.sh -N
>
> I have renamed the unit tests file to start with test_ and now I am seeing
> errors, which I will fix :)
>
> Dan
>
>
> On Tue, Aug 9, 2011 at 8:43 AM, Tyler Smith <email address hidden> wrote:
>
> > Review: Approve
> > Looks great to me. Unit tests for the renamed methods are failing, but
> > only because of the name change which I can fix along with the other
> updates
> > to the library we discussed once this merge goes through.
> > --
> > https://code.launchpad.net/~danwent/quantum/client-lib/+merge/70752
> > You are the owner of lp:~danwent/quantum/client-lib.
> >
>
>
>
> --
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Dan Wendlandt
> Nicira Networks, Inc.
> www.nicira.com | www.openvswitch.org
> Sr. Product Manager
> cell: 650-906-2650
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> https://code.launchpad.net/~danwent/quantum/client-lib/+merge/70752
> You are the owner of lp:~danwent/quantum/client-lib.
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
Sr. Product Manager
cell: 650-906-2650
~~~~~~~~~~~~~~~~~~~~~~~~~~~