Code review comment for lp://staging/~danwent/neutron/client-lib

Ok, now the client-lib unit tests should be run every time.

I also had to change the cli to use different call names... we really need
to get unit tests for the CLI and batch_config.py

dan

On Tue, Aug 9, 2011 at 9:13 AM, dan wendlandt <email address hidden> wrote:

> Great catch. I definitely want to fix the unit tests before committing.
> My
> confusion came from the fact that the client_lib unit tests aren't run when
> I do:
>
> ./run_tests.sh -N
>
> I have renamed the unit tests file to start with test_ and now I am seeing
> errors, which I will fix :)
>
> Dan
>
>
> On Tue, Aug 9, 2011 at 8:43 AM, Tyler Smith <email address hidden> wrote:
>
> > Review: Approve
> > Looks great to me. Unit tests for the renamed methods are failing, but
> > only because of the name change which I can fix along with the other
> updates
> > to the library we discussed once this merge goes through.
> > --
> > https://code.launchpad.net/~danwent/quantum/client-lib/+merge/70752
> > You are the owner of lp:~danwent/quantum/client-lib.
> >
>
>
>
> --
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Dan Wendlandt
> Nicira Networks, Inc.
> www.nicira.com | www.openvswitch.org
> Sr. Product Manager
> cell: 650-906-2650
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> https://code.launchpad.net/~danwent/quantum/client-lib/+merge/70752
> You are the owner of lp:~danwent/quantum/client-lib.
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
Sr. Product Manager
cell: 650-906-2650
~~~~~~~~~~~~~~~~~~~~~~~~~~~