Code review comment for lp://staging/~dannf/maas-images/lp1702976

Revision history for this message
Lee Trager (ltrager) wrote :

Is there any reason we need all i2c bus drivers on all architectures? I think we may want to do something like this to limit only the i2c-thunderx driver being added on arm64.

=== modified file 'bin/kpack-from-image'
--- bin/kpack-from-image 2017-05-09 14:04:12 +0000
+++ bin/kpack-from-image 2017-07-12 18:08:50 +0000
@@ -187,6 +187,10 @@
 copy_modules_dir kernel/drivers/char/ipmi # LP: #1333271
 copy_modules_dir kernel/drivers/net/usb # LP: #1552378
 manual_add_modules bcache # (LP: #1513176)
+# LP: #1702976
+if [ "$(uname -m)" == "arm64" ]; then
+ manual_add_modules i2c-thunderx
+fi
 EOF
     if [ "$rel" = "precise" ]; then
         echo "manual_add_modules squashfs # (LP: #1501834)" >> "$fname"

review: Needs Information

« Back to merge proposal