Code review comment for lp://staging/~danilo/launchpad/complex-forms

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Hi Danilo,

Sheer poetry. My main gripe—because I just _had_ to find one!—is that
you didn't turn the icons into sprites. Any chance of getting that in?

Also, in productseries-translations-settings.pt, the TAL still composes
links to branches the painful way, complete with icons. I was probably
guilty of that myself in the case of the export branch. Can't we use
fmt:link for these?

All this will break some pagetests, but I heard it will make our hair
glow with natural beauty and make our cars use less gasoline.

As for the whitespace cleanup: are you out to prove that emacs is good
for this? Not that I'd mind if you were. :-)

Jeroen

review: Approve

« Back to merge proposal