Code review comment for lp://staging/~danilo/launchpad/complex-forms

Revision history for this message
Данило Шеган (danilo) wrote :

= Bug #423103, #423104 =

Migrate a few "complex" forms: those which do use LaunchpadForm, but
embedded in a bigger page. Changes are mostly mechanical to make them
3.0-compatible.

== Implementation details ==

Lots of whitespace fixes (replacing tabs with spaces and similar) and
reindentation increase the size of the diff.

For translationimportqueueentry-index.pt, I also improve next_url
handling so we get back to the import queue which we started from
(basically, +imports page is registered on all of IProduct,
IProductSeries, IDistribution, IDistroSeries, IPerson, but they all go
to the same ITranslationImportQueueEntry edit form, and after
submission should go back). A separate test is added for that, though
it does exhibit some Zope testbrowser bugs in referrer handling.

Everything else is just bits and pieces moved around.

I've also moved translation import queue tests into a separate "story"
so they are easier to run when needed.

== Tests ==

bin/test -vvt stories.importqueue -t translations-xpi-import.txt -t productseries-translations-bzr-request -t distroseries-language-pack

== Demo and Q/A ==

translationsimportqueueentry-index.pt:

 https://translations.launchpad.dev/+imports/1
 (and get there through /+imports, /evolution/+imports, /~name16/+imports)

distroseries-language-packs.pt:

 https://translations.launchpad.dev/ubuntu/hoary/+language-packs

productseries-translations-bzr-import.pt:

 https://translations.launchpad.dev/evolution/trunk/+request-bzr-import

productseries-translations-settings.pt:

 https://translations.launchpad.dev/evolution/trunk/+translations-settings

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/stories/standalone/xx-translations-xpi-import.txt
  lib/lp/translations/stories/productseries/xx-productseries-translations-bzr-request.txt
  lib/lp/translations/stories/importqueue/xx-translation-import-queue-entry.txt
  lib/canonical/launchpad/pagetitles.py
  lib/lp/translations/templates/distroseries-language-packs.pt
  lib/lp/translations/browser/translationimportqueue.py
  lib/lp/translations/stories/importqueue/xx-translation-import-queue-filtering.txt
  lib/lp/translations/templates/productseries-translations-settings.pt
  lib/lp/translations/templates/productseries-translations-bzr-import.pt
  lib/lp/translations/stories/importqueue/xx-translation-import-queue.txt
  lib/lp/translations/browser/productseries.py
  lib/lp/translations/templates/translationimportqueueentry-index.pt
  lib/lp/translations/stories/importqueue/xx-translation-import-queue-edit-autofilling.txt
  lib/lp/translations/stories/distroseries/xx-distroseries-language-packs.txt

« Back to merge proposal