У пон, 13. 06 2011. у 14:38 +0000, Benji York пише:
> checkSubscriptionLevel doesn't really need to return anything (and the
> return value isn't used.
Good point, fixed.
> Unlike "nomal" HTML, YUI can understand self-closing divs, so on line
> 531 of the diff (in test_subscribers_list.js) so "<div></div>" can be
> replaced with "<div/>" on on lines 312, 464, 531, and 715 of the diff
> (in test_subscribers_list.js).
Yeah, I didn't know that about YUI. Brad just pointed that out in a
previous review so I fixed it in the code. Forgot about the tests
though, so now those are fixed as well :)
Thanks for the review.
У пон, 13. 06 2011. у 14:38 +0000, Benji York пише: onLevel doesn't really need to return anything (and the
> checkSubscripti
> return value isn't used.
Good point, fixed.
> Unlike "nomal" HTML, YUI can understand self-closing divs, so on line s_list. js) so "<div></div>" can be s_list. js).
> 531 of the diff (in test_subscriber
> replaced with "<div/>" on on lines 312, 464, 531, and 715 of the diff
> (in test_subscriber
Yeah, I didn't know that about YUI. Brad just pointed that out in a
previous review so I fixed it in the code. Forgot about the tests
though, so now those are fixed as well :)