Code review comment for lp://staging/~danilo/launchpad/bug-423136

Revision history for this message
Данило Шеган (danilo) wrote :

= Bug #423136 =

To do top alignment, I did a crappy thing by using absolute/relative
positioning. I should have just used float:left to stack span's one
next to each other so they end up top-aligned.

(Got a tip from a web coder friend sharing the office with me, and
since tested in Epiphany, Firefox 3.0, Konqueror, Opera and Chromium to
DTRT).

In appearance, nothing changes.

== Tests ==

bin/test -vvt potemplate-export -t stories.translationgroups

(55-rosetta-pofile-upload is part of translationgroups story)

== Demo and Q/A ==

https://translations.launchpad.dev/evolution/trunk/+pots/evolution-2.2/+export
https://translations.launchpad.dev/evolution/trunk/+pots/evolution-2.2/es/+upload

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/translations/templates/pofile-upload.pt
  lib/lp/translations/templates/potemplate-export.pt

« Back to merge proposal