Code review comment for lp://staging/~danilo/juju-core/bootstrap-verify

Revision history for this message
William Reade (fwereade) wrote :

LGTM, just one thought.

https://codereview.appspot.com/9876043/diff/21001/environs/storage.go
File environs/storage.go (right):

https://codereview.appspot.com/9876043/diff/21001/environs/storage.go#newcode38
environs/storage.go:38: return err
Might be nicer to log the actual error here, and return
fmt.Errorf("provider storage is not writable"), so the clients can all
just return non-nil errors unmodified.

https://codereview.appspot.com/9876043/

« Back to merge proposal