Merge lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/invert-failure-mode into lp://staging/~landscape/charms/trusty/glance-simplestreams-sync/landscape

Proposed by Данило Шеган
Status: Merged
Merged at revision: 66
Proposed branch: lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/invert-failure-mode
Merge into: lp://staging/~landscape/charms/trusty/glance-simplestreams-sync/landscape
Diff against target: 96 lines (+27/-46)
1 file modified
scripts/ (+27/-46)
To merge this branch: bzr merge lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/invert-failure-mode
Reviewer Review Type Date Requested Status
Geoff Teale (community) Approve
Bogdana Vereha (community) Approve
Review via email:

Description of the change

We've hit a number of cases where glance-simplestreams-sync script would fail due to swift, glance or something else not being fully ready, and had to extend it a number of times.

That has long pointed as at the fact that it'd be better to invert the logic there: only drop the per-minute cronjob on actual success.

This will mean that it will indefinitely retry even with fatal failures, but that's not a big deal for us, since our installation can take forever as well.

I'll do another test run before merging this in and after addressing all the review comments, fwiw.

To post a comment you must log in.
Revision history for this message
Bogdana Vereha (bogdana) wrote :

Looks good (considering the circumstances) :)

review: Approve
Revision history for this message
Geoff Teale (tealeg) wrote :

+1 - I guess it was inevitable ;-)

review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

Merged and pushed into cs:~landscape-charmers/trusty/glance-simplestreams-sync-8 and cs:~landscape-charmers/xenial/glance-simplestreams-sync-2

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches