Code review comment for lp://staging/~daniel-nichter/drizzle/query-log-plugin

Latest branch rev complies on FreeBSD now: http://jenkins.drizzle.org/job/drizzle-param-freebsd80/13/consoleText
The error at the end of that log is something else. The query_log plugin compiles though. Are there other tests it needs to pass?

-Daniel

Le 5 juin 2011 à 21:18, Daniel Nichter a écrit :
> Le 5 juin 2011 à 19:44, Mark Atwood a écrit :
>> Review: Needs Fixing
>> Fail Jenkins tests
>>
>> http://jenkins.drizzle.org/view/Drizzle-build/job/drizzle-build-ubuntu10.04-32bit/1315/consoleFull
>
> I dont' see any failures for that ^ build:
>
> query_log.check_query_log_attribute [ pass ] 90
> query_log.file [ pass ] 727
> query_log.thresholds [ pass ] 1110
>
>> http://jenkins.drizzle.org/view/Drizzle-build/job/drizzle-build-freebsd-8.0/1613/console
>
> This ^ is FreeBSD which I didn't test since it's not part of drizzle-param. When I test my branch, should I test with just drizzle-param or others? Is there a super job that will test on every platform on which code must pass?
>
> Thanks,
>
> Daniel
>
>
> --
> https://code.launchpad.net/~daniel-nichter/drizzle/query-log-plugin/+merge/61034
> You are the owner of lp:~daniel-nichter/drizzle/query-log-plugin.