Code review comment for lp://staging/~daniel-nichter/drizzle/query-log-plugin

I fixed compiler warnings in rev 2317 of the query-log-plugin branch. Turns out gcc on Mac OS doesn't support -Wmissing-declarations.

Le 2 juin 2011 à 19:48, Daniel Nichter a écrit :

> The latest query-log-plugin branch has fixed tests that now pass. Would anyone else like to review the code?
>
> Le 17 mai 2011 à 12:37, Mark Atwood a écrit :
>
>> Review: Needs Fixing
>> This is neat. It failed its own tests when I checked it on jenkens drizzle/build
>>
>> I also have a modified query log plugin to replace the one shipping now.
>>
>> We should sit down and reconcile them.
>>
>> .. mark
>> --
>> https://code.launchpad.net/~daniel-nichter/drizzle/query-log-plugin/+merge/61034
>> You are the owner of lp:~daniel-nichter/drizzle/query-log-plugin.
>
>
> --
> https://code.launchpad.net/~daniel-nichter/drizzle/query-log-plugin/+merge/61034
> You are the owner of lp:~daniel-nichter/drizzle/query-log-plugin.