Unity 8

Code review comment for lp://staging/~dandrader/unity8/miral

  1. miral
  2. Merge into trunk
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 18/11/2016 12:29, Michael Zanetti wrote:
>> - onMinimizeClicked: root.minimizeClicked();
>> >+ onMinimizeClicked: {
>> >+ if (applicationWindow.surface) {
>> >+ applicationWindow.surface.requestState(Mir.MinimizedState);
>> >+ }
>> >+ }
> this seems odd... why would you refactor DecoratedWindow to not directly operate on the data any more but instead pass everything outside with signals in a earlier branch, but now start introducing this somewhat messy behavior here again? IMO this should also be passed to outside to the Stage, and only the stage being in charge to actually execute things on the surfaces.
>
 That's some old change that pre-dates that branch you mentioned.
Reverted.

« Back to merge proposal