Merge lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup into lp://staging/ubuntu-ui-toolkit/staging
Status: | Merged |
---|---|
Approved by: | Zsombor Egri |
Approved revision: | 1341 |
Merged at revision: | 1362 |
Proposed branch: | lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup |
Merge into: | lp://staging/ubuntu-ui-toolkit/staging |
Diff against target: |
28 lines (+14/-3) 1 file modified
modules/Ubuntu/Components/Popups/PopupBase.qml (+14/-3) |
To merge this branch: | bzr merge lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Zsombor Egri | Approve | ||
Review via email: mp+242313@code.staging.launchpad.net |
This proposal supersedes a proposal from 2014-11-20.
Description of the change
This is needed by unity8 for the "shell rotation" feature (ie shell does all the rotation work instead of apps rotating themselves). unity8's dialogs (like the power dialog when you long press the power button) should follow its parent item rotation and size, as one would expect, and not be sneakily reparented to the scene root item, in which case the shell UI would be rotated but its dialog would not.
PPA with shell rotation:
https:/
And this is how unity8 is using Dialogs:
http://
Related bug: https:/
FAILED: Continuous integration, rev:1131 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/1239/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/6578/ console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- utopic- amd64-ci/ 1072 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- utopic- armhf-ci/ 1071 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- utopic- armhf-ci/ 1071/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- utopic- i386-ci/ 1071/console jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/6150/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/7830 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/7830/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 16035
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/1239/ rebuild
http://