Merge lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup into lp://staging/ubuntu-ui-toolkit
Status: | Superseded |
---|---|
Proposed branch: | lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup |
Merge into: | lp://staging/ubuntu-ui-toolkit |
Diff against target: |
45 lines (+13/-3) 2 files modified
components.api (+1/-0) modules/Ubuntu/Components/Popups/PopupBase.qml (+12/-3) |
To merge this branch: | bzr merge lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Ubuntu SDK team | Pending | ||
Review via email: mp+242312@code.staging.launchpad.net |
This proposal has been superseded by a proposal from 2014-11-20.
Commit message
Added PopupBase.
Some applications need Popups to behave as regular items and therefore
remain as children of their original parents (ie, no reparenting
to scene's root item behind the scenes).
This is the case when an application does its own UI rotation (which includes
any dialogs it might be displaying) where Popups should follow its parent
transformations (rotations) and resizes or when it doesn't want the Popup to cover
its entire scene.
Description of the change
This is needed by unity8 for the "shell rotation" feature (ie shell does all the rotation work instead of apps rotating themselves). unity8's dialogs (like the power dialog when you long press the power button) should follow its parent item rotation and size, as one would expect, and not be sneakily reparented to the scene root item, in which case the shell UI would be rotated but its dialog would not.
PPA with shell rotation:
https:/
And this is how unity8 is using Dialogs:
http://
FAILED: Continuous integration, rev:1131 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- ci/2178/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 288 jenkins. qa.ubuntu. com/job/ generic- mediumtests- vivid/199 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- vivid-amd64- ci/2 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- vivid-armhf- ci/2 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- vivid-armhf- ci/2/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 262 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 288 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 288/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 16034 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-vivid/ 176 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-amd64/ 203 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-amd64/ 203/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- ui-toolkit- ci/2178/ rebuild
http://