Merge lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup into lp://staging/ubuntu-ui-toolkit

Proposed by Daniel d'Andrada
Status: Superseded
Proposed branch: lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup
Merge into: lp://staging/ubuntu-ui-toolkit
Diff against target: 45 lines (+13/-3)
2 files modified
components.api (+1/-0)
modules/Ubuntu/Components/Popups/PopupBase.qml (+12/-3)
To merge this branch: bzr merge lp://staging/~dandrader/ubuntu-ui-toolkit/dontReparentPopup
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu SDK team Pending
Review via email: mp+242312@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-11-20.

Commit message

Added PopupBase.reparentToRootItem property

Some applications need Popups to behave as regular items and therefore
remain as children of their original parents (ie, no reparenting
to scene's root item behind the scenes).

This is the case when an application does its own UI rotation (which includes
any dialogs it might be displaying) where Popups should follow its parent
transformations (rotations) and resizes or when it doesn't want the Popup to cover
its entire scene.

Description of the change

This is needed by unity8 for the "shell rotation" feature (ie shell does all the rotation work instead of apps rotating themselves). unity8's dialogs (like the power dialog when you long press the power button) should follow its parent item rotation and size, as one would expect, and not be sneakily reparented to the scene root item, in which case the shell UI would be rotated but its dialog would not.

PPA with shell rotation:
https://launchpad.net/~unity-team/+archive/ubuntu/demo-stuff

And this is how unity8 is using Dialogs:
http://bazaar.launchpad.net/~unity-team/unity8/shellRotation/view/head:/qml/Components/Dialogs.qml

To post a comment you must log in.
1338. By Daniel d'Andrada

Added PopupBase.reparentToRootItem property

Some applications need Popups to behave as regular items and therefore
remain as children of their original parents (ie, no reparenting
to scene's root item behind the scenes).

This is the case when an application does its own UI rotation (which includes
any dialogs it might be displaying) where Popups should follow its parent
transformations (rotations) and resizes or when it doesn't want the Popup to cover
its entire scene.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1339. By Daniel d'Andrada

Make it a hidden property

1340. By Daniel d'Andrada

Remove it from components.api

1341. By Daniel d'Andrada

merge staging

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: